Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable git release tagging #184

Open
svange opened this issue Aug 7, 2024 · 0 comments
Open

Re-enable git release tagging #184

svange opened this issue Aug 7, 2024 · 0 comments
Assignees
Labels
ci Continuous integration, especially pipelines enhancement New feature or request

Comments

@svange
Copy link
Owner

svange commented Aug 7, 2024

Description

The CI pipeline used to trigger twice per run, once when the branch was pushed, and then again when semantic-release tagged the branch. This required every task in the file to have a conditional to skip if it's the tag. This was required because the pipeline had to get all the way back to the publish task in order for semantic-release to tag the repo, and allowing any task to fail along the way causes the deploy stage needs statement to fail.

Possible Solution

Move publish to separate workflow and mark it on-workflow-call and tags == "v*".

Additional context

No response

Additional context

No response

@svange svange added enhancement New feature or request ci Continuous integration, especially pipelines labels Aug 7, 2024
@svange svange self-assigned this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration, especially pipelines enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant