fix: adjust $props() comment type logic (#2294)

Look at the last comment before the node first, check for `@type` and prevent `@typedef` false positive sveltejs/svelte#10541 (comment)
sveltejs · Feb 20, 2024 · 1b5e913 · 1b5e913
1 parent efe8463
commit 1b5e913
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/svelte2tsx/src/svelte2tsx/nodes/ExportedNames.ts b/packages/svelte2tsx/src/svelte2tsx/nodes/ExportedNames.ts
@@ -187,18 +187,21 @@ export class ExportedNames {
                 const text = node.getSourceFile().getFullText();
                 let start = -1;
                 let comment: string;
-                for (const c of ts.getLeadingCommentRanges(text, node.pos) || []) {
+                // reverse because we want to look at the last comment before the node first
+                for (const c of [...(ts.getLeadingCommentRanges(text, node.pos) || [])].reverse()) {
                     const potential_match = text.substring(c.pos, c.end);
-                    if (potential_match.includes('@type')) {
+                    if (/@type\b/.test(potential_match)) {
                         comment = potential_match;
                         start = c.pos + this.astOffset;
                         break;
                     }
                 }
                 if (!comment) {
-                    for (const c of ts.getLeadingCommentRanges(text, node.parent.pos) || []) {
+                    for (const c of [
+                        ...(ts.getLeadingCommentRanges(text, node.parent.pos) || []).reverse()
+                    ]) {
                         const potential_match = text.substring(c.pos, c.end);
-                        if (potential_match.includes('@type')) {
+                        if (/@type\b/.test(potential_match)) {
                             comment = potential_match;
                             start = c.pos + this.astOffset;
                             break;