Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable warnings .svelte editors #6

Closed
chriscalo opened this issue Oct 7, 2019 · 3 comments
Closed

Add option to disable warnings .svelte editors #6

chriscalo opened this issue Oct 7, 2019 · 3 comments

Comments

@chriscalo
Copy link

The warnings are a distraction because things work fine without addressing them.

@rixo
Copy link
Contributor

rixo commented Feb 15, 2022

I believe you're mentioning erroneous warnings that were caused by lacking compatibility of this plugin with Svelte 3.

In the new version (1.0.0) of this plugin, any error/warning that you see should be an actual problem.

If really you want to disable even non-erroneous warnings, this would be done in the linter package. (Unfortunately, at the time of writing, disabling the kind of linters provided by this plugin is not supported in the linter, which is what I personally use -- don't know if this applies to your situation).

I'm closing this because the formulation "because things work fine without addressing them" makes me think that the actual request was about erroneous warnings, which should be fixed now.

If someone is really interested in a "disable diagnostics" feature, this might be doable. Please open a new issue and we'll consider it.

@rixo rixo closed this as completed Feb 15, 2022
@rixo
Copy link
Contributor

rixo commented Feb 16, 2022

Well... Turns out we are now linting JS Component with TS, resulting in type warnings & errors that do fall in the "erroneous linting" category.

I guess an option to disable TS diagnostics is needed indeed. I suppose it should be enabled by default for TS, and disabled for JS.

@rixo rixo reopened this Feb 16, 2022
@rixo
Copy link
Contributor

rixo commented Feb 17, 2022

Should be fixed in v1.1.0, that adds options to disable diagnostics for ts, js, or svelte.

@rixo rixo closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants