fix: correct each block update index type (#9425)

* fix: correctly handle index within each block updates * changeset
sveltejs · Nov 13, 2023 · 5a6afe5 · 5a6afe5 · vercel · Nov 13, 2023
1 parent 1daadc3
commit 5a6afe5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/eight-steaks-shout.md b/.changeset/eight-steaks-shout.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: correct update_block index type
diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js
@@ -2078,7 +2078,7 @@ function get_first_element(block) {
 /**
  * @param {import('./types.js').EachItemBlock} block
  * @param {any} item
- * @param {import('./types.js').MaybeSignal<number>} index
+ * @param {number} index
  * @param {number} type
  * @returns {void}
  */
@@ -2093,7 +2093,6 @@ export function update_each_item_block(block, item, index, type) {
 		let prev_index = block.index;
 		if (index_is_reactive) {
 			prev_index = /** @type {import('./types.js').Signal<number>} */ (prev_index).value;
-			index = /** @type {import('./types.js').Signal<number>} */ (index).value;
 		}
 		const items = block.parent.items;
 		if (prev_index !== index && /** @type {number} */ (index) < items.length) {