-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: fix 404 page by upgrading SvelteKit and avoiding null reference #9337
Conversation
|
gah!! well we might as well upgrade anyway, but yeah it looks like we have something else to fix too the lint failure is unrelated. I just sent another PR for that: #9338 |
I rebased this against |
Some thoughts on this issue sveltejs/kit#10565 (comment)
TypeError: Cannot read properties of null (reading 'startsWith') but the error message being incorrect is a sveltekit issue |
I sent sveltejs/kit#10911 to fix the types in SvelteKit. And I pushed a commit here to allow the 404 page to render correctly: ed30ebb |
will fix 404s sometimes being returned as 500s as discussed in #9116 (comment)