Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add support to remove custom parameters from url #141

Open
Enkidu70 opened this issue Dec 28, 2022 · 5 comments
Open

Feature request: add support to remove custom parameters from url #141

Enkidu70 opened this issue Dec 28, 2022 · 5 comments

Comments

@Enkidu70
Copy link

Enkidu70 commented Dec 28, 2022

In followup to #44 & #70:

Minimum feature request:

Please implement a solution to make Leon able remove a specific set of parameters from URLs, like

  • clever*

Many websites use same analytic software for campain & user tracking. The name prefix above are a very common one and Léon should be able to generally remove them, with all of their variations.

Exampel URL:

https://www.ruhr24.de/service/krankenkasse-beitrag-steigt-aok-barmer-tk-guenstig-24h-r24-dak-versicherung-deutschland-zusatz-91998261.html#?cleverPushBounceUrl=https%3A%2F%2Fwww.ruhr24.de%2Fservice%2F&cleverPushNotificationId=yMlhjgj4gsLdgfjhjhgfYdnGCYDEyc

Real necessary:

https://www.ruhr24.de/service/krankenkasse-beitrag-steigt-aok-barmer-tk-guenstig-24h-r24-dak-versicherung-deutschland-zusatz-91998261.html#

Maximum feature request:

In addition to min. feature request, it would be very helpful to be able to add own parameter patterns.

E.g. like "_ref="

Real high end idea:

Enable community of active Léon users to provide their custom parameter list.

Why?

Keep URL short, keep privacy and empower the user to remove unwanted stuff.

Tnx in advance,
Enkidu

@svenjacobs
Copy link
Owner

svenjacobs commented Dec 28, 2022

Hello @Enkidu70, thanks for your feedback.

Regarding utm* parameters, they should already be removed by the Google Analytics sanitizer. Is this not the case?

@Enkidu70
Copy link
Author

Sorry, concerning utm* you are right. Don't know what went wrong on my side...

@svenjacobs
Copy link
Owner

I agree that custom parameters would be a nice feature. However this would also be the most complex feature to date. I think we should start small and first only allow configuring exact parameter names which should be removed. Regular expressions add quite some complexity and possible problems (see my concerns here). Maybe later we can even add an option to import/export custom parameters?

@Enkidu70
Copy link
Author

Well... Exact seems to be a lot of names concerning "clever" parameters. 🤣

What about adding fixed pattern like "clever*=" as new filter? 🙏 😀

@svenjacobs
Copy link
Owner

@Enkidu70 I've been thinking about the custom rules feature. Please provide your feedback in the discussion item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants