Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another parameter not removed (intercom.com) #303

Open
serrq opened this issue Oct 19, 2023 · 5 comments
Open

Another parameter not removed (intercom.com) #303

serrq opened this issue Oct 19, 2023 · 5 comments
Assignees
Labels
blocked Blocked by other issue feature New feature or request

Comments

@svenjacobs
Copy link
Owner

New sanitizers are currently blocked because I'm rewriting the internals of Leon.

@svenjacobs svenjacobs added feature New feature or request blocked Blocked by other issue labels Nov 1, 2023
@svenjacobs svenjacobs self-assigned this Nov 1, 2023
@svenjacobs svenjacobs changed the title Another parameter not removed Another parameter not removed (intercom.com) Nov 1, 2023
@svenjacobs
Copy link
Owner

Does it really make sense to have a cleaner for a specific unsubscribe page of a service?

I think once the refactoring of Leon is done, where users can manually select parameters for removal, this sanitizer would not be required, right?

I would like to only add sanitizers that make sense for the broader audience. We already have quite a few sanitizers in Leon and with every sanitizer the complexity and maintenance of the app increases.

@jmbreuer
Copy link
Contributor

The way I see this (and the way I read what information I can find on it), it would make sense to remove mkt_tok specifically whenever mkt_unsubscribe=1 is not present - i.e. in all cases where it's a tracked link that's not used to unsubscribe.

mkt_tok is an URL parameter used by Adobe's Marketo Engage.

@serrq
Copy link
Author

serrq commented Nov 1, 2024

Maybe this is not an error.

I believe that tok parameter is a kind of the recipient towards whose the "bullet" has to hit its target.

So the manually cleaned works, but with no effect.

This is my sensation (feeling?!?!?)

@svenjacobs
Copy link
Owner

mkt_tok is an URL parameter used by Adobe's Marketo Engage.

Then I guess it makes sense to have a generic cleaner for Marketo Engage that removes all mkt_* parameters just like we have a cleaner for Google Analytics (utm_*)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by other issue feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants