Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<base> tag breaks SVG marker rendering #568

Closed
grzhan opened this issue Jan 13, 2017 · 3 comments
Closed

<base> tag breaks SVG marker rendering #568

grzhan opened this issue Jan 13, 2017 · 3 comments
Assignees
Labels

Comments

@grzhan
Copy link

grzhan commented Jan 13, 2017

See http://stackoverflow.com/questions/18259032/using-base-tag-on-a-page-that-contains-svg-marker-elements-fails-to-render-marke

Maybe we need add a parameter in SVG.Marker to support fully resolve the marker url.

@wout
Copy link
Member

wout commented Jan 13, 2017

We've had this question before. This issue affects all url() references. We'll have to add this to the to-do. Maybe make a utility function that we can use everywhere an url reference is made.

@Fuzzyma
Copy link
Member

Fuzzyma commented Jan 13, 2017

I was searching for that issue and found this one: #36. But actually I thought there was another one.
We decided to let this at it is because it added other problems with references. However, I dont know which one anymore...

@wout
Copy link
Member

wout commented Jan 13, 2017

Thought so too and found it!

svgdotjs/svg.filter.js#1

I think we must indeed be careful with exporting. All url() references should then be converted on export.

@wout wout added this to the 3.0.0 milestone Feb 13, 2017
Fuzzyma added a commit that referenced this issue Apr 23, 2017
the prefix is removed on export and added on import
This was referenced Apr 23, 2017
@Fuzzyma Fuzzyma removed this from the 3.0.0 milestone May 27, 2018
@Fuzzyma Fuzzyma closed this as completed May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants