-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't resolve '@swagger-api/apidom-json-pointer' in latest release #4539
Comments
Same error here, justly using @backstage/plugin-api-docs |
swagger-client webpack bundling totally fails also for us |
Looks like adding a resolution for "resolutions": {
"@types/react": "^18",
"@types/react-dom": "^18",
+ "@swagger-api/apidom-json-pointer": "1.0.0-alpha.10" |
I found the problem in @swagger-api/apidom-reference in version 1.0.0-alpha.10 you define in optionalDependencies "@swagger-api/apidom-json-pointer": "^1.0.0-alpha.1", it means it install the version 1.0.0-beta.0, while it is supposed to limit like in swagger-client to
|
in fact it may be the same for all you optional dependencies.
otherwise you must upgrade swagger-client to the beta version |
Hi everybody. Working on it. |
First fix provided in https://github.com/swagger-api/apidom/releases/tag/v1.0.0-beta.1 Next fix comming in couple of minutes. |
Second fix provided in #4549 |
Hi @paztis
swagger-client shouldn't pull betas automatically. It's has been prevented by following version constraints: "@swagger-api/apidom-core": ">=1.0.0-alpha.9 <1.0.0-beta.0",
"@swagger-api/apidom-error": ">=1.0.0-alpha.9 <1.0.0-beta.0",
"@swagger-api/apidom-json-pointer": ">=1.0.0-alpha.9 <1.0.0-beta.0",
"@swagger-api/apidom-ns-openapi-3-1": ">=1.0.0-alpha.9 <1.0.0-beta.0",
"@swagger-api/apidom-reference": ">=1.0.0-alpha.9 <1.0.0-beta.0", |
Release in progress https://github.com/swagger-api/apidom/actions/runs/11971775640/job/33377284820 |
Fix released in https://github.com/swagger-api/apidom/releases/tag/v1.0.0-beta.2. Thanks for you patience. |
Wait. The problem is on 1.0.0-alpha.10 version, not on beta.0 If you didn't upgrade swagger-client, you must deliver a 1.0.0-alpha.11 with fixes |
@paztis there is no issue with alpha.10. Alpha.10 has been released a month ago. Can you elaborate? |
All the issue I explain you is due to alpha.10 I. Alpha 10 delivery, you declare optionalDep of ^1.0.0-alpha.1 So if anyone install an alpha.10 it get beta.0 of the deps installed and this is what is crashing As swagger-client continue to point to last alpha, your fix will not resolve anything The only solution is to release an alpha.11 with the fix or re-release alpha 10 |
With your current management, each time you release a beta with breaking changes, all the alpha are broken. |
The problem is mostly visible in the monorepos |
Ok thank you I understand now, it's here: https://github.com/swagger-api/apidom/blob/main/packages/apidom-reference/package.json#L270. There is no upper boundary. So the |
Yes that's it |
What I can do is fix that in next beta release and release a new swagger-client with that fix beta as lowest boundary. You can then pin your swagger-client to safeguard for future. alpha and beta are fully compatible and there is no plan to break the compatibility in beta. We'll not be releasing fixed alpha release. Would that work for you? |
If it is BWC it's ok for me |
Reopening as we have to provider upper boundary for the optional dependencies. |
Hey folks, we're seeing the below in our build, seems related to this thread? Is there a workaround? I've tried the suggestions in the thread, no luck.
|
Looks like the latest release that went out appears to have broken our tests.
Wondering if this is a bad publish?
Additional build logs here: https://github.com/backstage/backstage/actions/runs/11952606327/job/33318690026
The text was updated successfully, but these errors were encountered: