Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest open source publish of libswiftnav #2

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dgburr
Copy link
Contributor

@dgburr dgburr commented Nov 8, 2023

An open source publish of libswiftnav was done on 2023-09-30 (see swift-nav/libswiftnav@f329a40) but the public version of gnss-converters was not updated correspondingly. This PR updates libswiftnav to f329a4052f36183fb5b094486a31a2ed7e970d8a plus the minimum amount of changes required to compile due changes upstream.

An alternative to this PR would be to do a new open source publish to gnss-converters (which is probably a good idea anyway, given that it was last done on 2022-02-04).

@dgburr dgburr marked this pull request as draft November 8, 2023 14:50
Copy link

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really just publish an open source drop off gnss-converters instead of doing it this way.

I worry it's going to be a mess to reconcile the two mirrors later down the line if we do it this way.

@dgburr
Copy link
Contributor Author

dgburr commented Nov 8, 2023

We should really just publish an open source drop off gnss-converters instead of doing it this way.

I worry it's going to be a mess to reconcile the two mirrors later down the line if we do it this way.

Yes, agreed. Who do I need to ask in order to get this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants