Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button snapshots #2020

Closed
alizedebray opened this issue Oct 2, 2023 · 0 comments · Fixed by #2021
Closed

Fix button snapshots #2020

alizedebray opened this issue Oct 2, 2023 · 0 comments · Fixed by #2021
Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package
Milestone
Maintenance

Comments

@alizedebray
Copy link
Contributor

Since #1085 the buttons use the post-icon component, however the snapshot does not wait until the icon is shown (it takes some ms to load).

Percy snapshot of the buttons

Snapshot story for buttons
@alizedebray alizedebray added 🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package labels Oct 2, 2023
@alizedebray alizedebray added this to the Maintenance milestone Oct 2, 2023
@alizedebray alizedebray mentioned this issue Oct 2, 2023
Merged
@imagoiq imagoiq linked a pull request Oct 3, 2023 that will close this issue
test(snapshots): Wait for icons #2021
Merged
@imagoiq imagoiq closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Design System Production Board Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package
Projects
Design System Production Board
Archived in project
Milestone
Maintenance
Development

Successfully merging a pull request may close this issue.

test(snapshots): Wait for icons swisspost/design-system
2 participants
@imagoiq @alizedebray