Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component]: Breadcrumb #3207

Closed
5 of 6 tasks
gfellerph opened this issue Jul 2, 2024 · 0 comments · Fixed by #4065
Closed
5 of 6 tasks

[component]: Breadcrumb #3207

gfellerph opened this issue Jul 2, 2024 · 0 comments · Fixed by #4065
Assignees
Labels
📦 components Related to the @swisspost/design-system-components package

Comments

@gfellerph
Copy link
Member

gfellerph commented Jul 2, 2024

Migrate the breadcrumb list component to the packages/components package.

Proposed markup structure

<post-breadcrumb home-url="/" home-text="Go home">
  <post-breadcrumb-item href="/">Link 1</post-breadcrumb-item>
  <post-breadcrumb-item>Current</post-breadcrumb-item>
</post-breadcrumb>

Alternative markup structure to make it easier to put items in the dropdown and mark the last breadcrumb item:

<post-breadcrumb>
    <post-breadcrumb-item></post-breadcrumb-item>
    <post-breadcrumb-item></post-breadcrumb-item>
    <post-breadcrumb-item></post-breadcrumb-item>
    <post-breadcrumb-item></post-breadcrumb-item>
    <post-breadcrumb-current></post-breadcrumb-current>
</post-breadcrumb>

Props

  • homeURL: A valid URL to use on the home icon
  • homeText: Accessible name for the home icon

Default slot

Only allowed children are <post-breadcrumb-item> elements.

Notes

  • Renders a hidden section with the full length of items to check if there is enough space for all items before rendering the real items. If there is not enough space, ellipsis with a dropdown should render that lists all breadcrumb items but the last. If the last breadcrumb item does not have enough space to fully render, it should end in ellipsis. It should never overflow nor flow on two lines.

💻 Tasks

Preview Give feedback
  1. 2 of 3
    📦 components
    alionazherdetska
  2. 📦 components
    alionazherdetska
@gfellerph gfellerph added the 📦 components Related to the @swisspost/design-system-components package label Jul 2, 2024
@gfellerph gfellerph added this to the Post Header Basics milestone Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 🗃️ Ready for work in Design System Production Board Jul 2, 2024
@gfellerph gfellerph moved this from 🗃️ Ready for work to 👀 Triage in Design System Production Board Jul 3, 2024
@gfellerph gfellerph added the 💭 draft Issue is not ready for development label Jul 3, 2024
@gfellerph gfellerph changed the title Component: Breadcrumb list [component]: Breadcrumb list Jul 25, 2024
@gfellerph gfellerph changed the title [component]: Breadcrumb list [component]: Breadcrumbs Jul 25, 2024
@gfellerph gfellerph removed the 💭 draft Issue is not ready for development label Jul 25, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💎 Ready for development in Design System Production Board Aug 14, 2024
@gfellerph gfellerph changed the title [component]: Breadcrumbs [component]: Breadcrumb Aug 14, 2024
@alionazherdetska alionazherdetska linked a pull request Nov 25, 2024 that will close this issue
@alionazherdetska alionazherdetska moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 components Related to the @swisspost/design-system-components package
Projects
Status: 🚀 Done
2 participants