Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tokens]: Create new output file combinations for channel & theme tokens #3312

Closed
1 of 3 tasks
gfellerph opened this issue Jul 22, 2024 · 0 comments · Fixed by #3349
Closed
1 of 3 tasks

[tokens]: Create new output file combinations for channel & theme tokens #3312

gfellerph opened this issue Jul 22, 2024 · 0 comments · Fixed by #3349
Assignees
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone

Comments

@gfellerph
Copy link
Member

gfellerph commented Jul 22, 2024

Description

New output file combinations are necessary to handle tokens. Create output files for each theme/channel combination, following the schema [theme]-[channel].scss.

  • post-external.scss
  • post-internal.scss

Notes:
Sample imports for post-external.scss:

// Semantic layer (order needs to be tested, should match the order in Token Studio)
@use "/tokens/_modes";
@use "/tokens/_devices";
@use "/tokens/_external";
@use "/tokens/_post-theme";

@use "/components";

Tasks

💻 Tasks

Preview Give feedback
@gfellerph gfellerph added the 📦 components Related to the @swisspost/design-system-components package label Jul 22, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed 📦 components Related to the @swisspost/design-system-components package labels Jul 22, 2024
@gfellerph gfellerph added this to the Components v2 milestone Jul 24, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💎 Ready for development in Design System Production Board Jul 24, 2024
@gfellerph gfellerph self-assigned this Jul 24, 2024
@gfellerph gfellerph moved this from 💎 Ready for development to 🕹️ Coding in progress in Design System Production Board Jul 24, 2024
@gfellerph gfellerph linked a pull request Jul 24, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this from 🕹️ Coding in progress to 🚀 Done in Design System Production Board Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Development

Successfully merging a pull request may close this issue.

1 participant