Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: final step breaks with lengthier words #3977

Closed
Gabko14 opened this issue Nov 13, 2024 · 2 comments · Fixed by #4055
Closed

Stepper: final step breaks with lengthier words #3977

Gabko14 opened this issue Nov 13, 2024 · 2 comments · Fixed by #4055
Assignees
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package v8

Comments

@Gabko14
Copy link

Gabko14 commented Nov 13, 2024

Hello Design System Team and @alizedebray @oliverschuerch

I have a problem regarding the stepper. The last element seems to have less capacity to handle lengthy words like "Zusammenfassung" for example.

Screenshot:
Image

Adding a word break could technically fix this, but it is not the desired approach. I also cannot make the whole stepper wider because there is no space.

This worked well with the ngb-progressbar implementation.

Thank you for your help

@gfellerph gfellerph added 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package v8 labels Nov 16, 2024
@gfellerph
Copy link
Member

Tried to reconstruct how it looked with the ngb-progressbar in older versions, but was not really able to produce a desirable result:

v5
Image
https://6401b58ebf0f4e298ee2dbe7--swisspost-web-frontend.netlify.app/#/post-samples/stepper

v8
Image
https://archive.design-system.post.ch/#/post-samples/stepper

Do you have a screenshot of how you'd expect it to look and what version of the Design System are you on?

From my point of view, the only two options would be truncation (adding three dots and cutting the word like "Zusammen....") and breaking it to a new line. Truncation is generally not desired from an accessibility standpoint because you'd need to offer an alternative way to display the full word like adding the title attribute or a tooltip, but only when the word is too long to display fully - and that's not always easy to detect.

@gfellerph gfellerph added the question Further information is requested label Nov 16, 2024
@Gabko14
Copy link
Author

Gabko14 commented Nov 18, 2024

Thank you very much for taking your time to analyze this

v8.2.1
Image

v6.2
Image

I have intentionally placed the word "zusammenfassung" in 3 different steps to showcase that it's only the last step which starts to panic once it contains a word with a few more characters than usual

@gfellerph gfellerph removed the question Further information is requested label Nov 19, 2024
@gfellerph gfellerph added this to the Long Term Support milestone Nov 19, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Nov 20, 2024
@leagrdv leagrdv self-assigned this Nov 22, 2024
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Nov 22, 2024
@leagrdv leagrdv moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 19, 2024
@leagrdv leagrdv closed this as completed by moving to 🚀 Done in Design System Production Board Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment