Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated size variables ($size-hair, $size-line, etc) #4173

Closed
1 task
myrta2302 opened this issue Dec 6, 2024 · 0 comments · Fixed by #4343
Closed
1 task

Remove deprecated size variables ($size-hair, $size-line, etc) #4173

myrta2302 opened this issue Dec 6, 2024 · 0 comments · Fixed by #4343
Assignees
@leagrdv
Labels
💔 breaking This is a breaking change and results in a new major version 📦 styles Related to the @swisspost/design-system-styles package
Milestone
PPNL Support

Comments

@myrta2302
Copy link
Contributor

myrta2302 commented Dec 6, 2024 •
edited by gfellerph
Loading

  • Remove declaration of post-sizes deprecated variables from 'styles/variables/_spacing.scss'
  • Replace these variables where used

Tasks
Preview Give feedback
@myrta2302 myrta2302 added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Dec 6, 2024
@myrta2302 myrta2302 changed the title Remove deprecated sizes variables ($size-hair, $size-line, etc) Remove deprecated size variables ($size-hair, $size-line, etc) Dec 6, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package 💔 breaking This is a breaking change and results in a new major version and removed needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Dec 12, 2024
@gfellerph gfellerph added this to the PPNL Support milestone Dec 16, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 16, 2024
@leagrdv leagrdv self-assigned this Dec 18, 2024
@leagrdv leagrdv moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 18, 2024
@leagrdv leagrdv linked a pull request Dec 19, 2024 that will close this issue
chore(styles, documentation): remove usage of deprecated utility sizing classes #4343
Merged
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
💔 breaking This is a breaking change and results in a new major version 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
3 participants
@gfellerph @myrta2302 @leagrdv