Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default slot on host for post-logo #4276

Closed
2 tasks
gfellerph opened this issue Dec 13, 2024 · 0 comments · Fixed by #4345
Closed
2 tasks

Remove default slot on host for post-logo #4276

gfellerph opened this issue Dec 13, 2024 · 0 comments · Fixed by #4345
Assignees
@schaertim
Labels
📦 components Related to the @swisspost/design-system-components package 📦 documentation Related to the @swisspost/design-system-documentation package
Milestone
PPNL Support

Comments

@gfellerph
Copy link
Member

The <post-logo> has a default slot on the host element. According to #4183, this should not be used because the logo is a standalone component that can be used without a specific parent.

Tasks
Preview Give feedback
@gfellerph gfellerph added 📦 components Related to the @swisspost/design-system-components package 📦 documentation Related to the @swisspost/design-system-documentation package labels Dec 13, 2024
@gfellerph gfellerph added this to the PPNL Support milestone Dec 13, 2024
@gfellerph gfellerph mentioned this issue Dec 13, 2024
Open
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 16, 2024
@schaertim schaertim self-assigned this Dec 19, 2024
@schaertim schaertim moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 19, 2024
@schaertim schaertim linked a pull request Dec 19, 2024 that will close this issue
chore(components, docs): removed auto slotting from post-logo #4345
Merged
@schaertim schaertim moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
📦 components Related to the @swisspost/design-system-components package 📦 documentation Related to the @swisspost/design-system-documentation package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

chore(components, docs): removed auto slotting from post-logo swisspost/design-system
2 participants
@gfellerph @schaertim