-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): HCM on form validation icons #4319
base: main
Are you sure you want to change the base?
fix(styles): HCM on form validation icons #4319
Conversation
🦋 Changeset detectedLatest commit: edeea51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$encoded-color: encode-color($color); | ||
$icon: utilities.replace(forms.$valid-icon, '%23107800', $encoded-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a function you can used for that in packages/styles/src/functions/_icons.scss. It is called add-fill-color
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is my variable is not a svg but a url('...')
. I tried removing the url() wrapper but I get an error in the console telling me it's invalid and missing a ;
and I don't get why. Do you have any idea why I get an error with that? And if I try to use it as it in the fill function, it does not work.
…-high-contrast-mode-across-form-elements
Quality Gate passedIssues Measures |
No description provided.