Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): HCM on form validation icons #4319

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 17, 2024

No description provided.

@leagrdv leagrdv requested a review from a team as a code owner December 17, 2024 13:29
@leagrdv leagrdv requested a review from alizedebray December 17, 2024 13:29
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: edeea51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 17, 2024

Related Previews

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiple select has a chevron icon that should not be there:
image

Comment on lines +59 to +60
$encoded-color: encode-color($color);
$icon: utilities.replace(forms.$valid-icon, '%23107800', $encoded-color);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a function you can used for that in packages/styles/src/functions/_icons.scss. It is called add-fill-color.

Copy link
Contributor Author

@leagrdv leagrdv Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is my variable is not a svg but a url('...'). I tried removing the url() wrapper but I get an error in the console telling me it's invalid and missing a ; and I don't get why. Do you have any idea why I get an error with that? And if I try to use it as it in the fill function, it does not work.

Copy link

sonarcloud bot commented Dec 17, 2024

@leagrdv leagrdv requested a review from alizedebray December 18, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HCM: Align form validation icon color in high contrast mode across form elements
3 participants