Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Focus moves to hidden links in closed accordion items in Footer #4296

Open
alionazherdetska opened this issue Dec 15, 2024 · 2 comments · May be fixed by #4309
Open

[bug]: Focus moves to hidden links in closed accordion items in Footer #4296

alionazherdetska opened this issue Dec 15, 2024 · 2 comments · May be fixed by #4309
Assignees
@myrta2302
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@alionazherdetska
Copy link
Contributor

Description:
When navigating through the accordion items in the footer using the tab, the focus incorrectly moves sequentially through all links inside closed accordion items before reaching the next accordion header. This behavior causes confusion and violates accessibility expectations.

Steps to Reproduce:

  1. Open the Composible Footer page.
  2. Ensure all accordion items are closed.
  3. Use the tab to navigate through the accordion items.
  4. Observe that the focus moves through the links inside the closed accordion items before it reaches the next accordion header.
@alionazherdetska alionazherdetska added the 🐞 bug Something isn't working label Dec 15, 2024
@alionazherdetska alionazherdetska added this to the PPNL Components milestone Dec 15, 2024
@gfellerph gfellerph added the 📦 components Related to the @swisspost/design-system-components package label Dec 16, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 16, 2024
@gfellerph
Copy link
Member

Check if this applies to all accordions.

@myrta2302 myrta2302 self-assigned this Dec 16, 2024
@myrta2302 myrta2302 moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 16, 2024
@myrta2302 myrta2302 linked a pull request Dec 16, 2024 that will close this issue
chore(components): disable focus when accordion item collapsed #4309
Open
@myrta2302
Copy link
Contributor

myrta2302 commented Dec 16, 2024 •
edited
Loading

Bug present in any accordion (collapsible), with items containing focusable elements.

@myrta2302 myrta2302 moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myrta2302 myrta2302

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

chore(components): disable focus when accordion item collapsed swisspost/design-system
3 participants
@gfellerph @myrta2302 @alionazherdetska