-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications and Darkmode #4307
Comments
Resolution from Pattern discussion: Use a workaround for the header and footer (setting An improvement to data-color-scheme would also be to set the correct text color that should apply in this mode and not only the semantic variables. Alternative to create web components for banners just to read out the resolved token: add banner classes to the light scheme selector for semantic layer tokens because we know they're all light (might break if one of them ever has a dark background but is faster to implement). |
Outsourced into a discussion: #4511, closing this issue. |
Notification components (Banner, Toast etc) can have multiple elements in them. How do we handle that the components know what scheme to use? Can we set the components to light only? What happens if a theme needs the component in a darker tone?
The text was updated successfully, but these errors were encountered: