Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): added missing hcm styles for radio-button and checkbox #4334

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

schaertim
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 25b3d12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 18, 2024

Related Previews

…nd-color-and-selecteditemtext-text-color-for-checkbox-and-radio-button-in-selected-state
@schaertim schaertim marked this pull request as ready for review December 19, 2024 07:30
@schaertim schaertim requested a review from a team as a code owner December 19, 2024 07:30
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels are not showing in Firefox.

…nd-color-and-selecteditemtext-text-color-for-checkbox-and-radio-button-in-selected-state
…nd-color-and-selecteditemtext-text-color-for-checkbox-and-radio-button-in-selected-state
@include utility-mx.high-contrast-mode() {
background-color: SelectedItem;
}

&::after {
background-color: currentColor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can select any color for HCM, the indicator should use the SelectedItemText color to ensure it is always visible.
Same for the radio buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants