-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hook searching #311
Comments
Wouldn't it be simpler to just add a query parameter to the routes/listeners resources? |
I thought about query parameters too but avoided them because regex patterns could not be defined. There could be more fields to search for like for example x-queue-headers which are set or something else. We could in fact just provide a single query parameter (q) and search over all fields in the resource with a full-text search. WDYT? |
I fear a bit of overengineering. Regexp are not necessary, I think. |
OK to recap what's todo in this issue:
|
With the current implementation, hooks (in the storage) can be searched by calling the configured hook uri. For example:
Hooks can only be found based on the names and encoded urls shown in the examples above.
Looking at a specific hook, there are more information which could be useful to search for:
Properties like requesturl and destination could be good candidates to search for.
Hook search API
Adopt the HookHandler class (or a suitable other handler) to handle hook searching requests.
These requests could look something like this:
The text was updated successfully, but these errors were encountered: