-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a file with mimeapp creates a child process. #194
Comments
Done by #216, please give it a try! |
Just compiled from the pr-5202b9db branch and set the orphan = true and it works perfectly! Thanks! |
Thank you for testing, merged! |
Hi guys, I don’t want to clutter this closed thread; but Setup: Void Linux, glibc, wayland, river. Also roughly tested yazi under xorg + i3 to ensure that wayland does not cause the problem. Is this a yazi bug on linux, and is there anything I can do to help you test this? Am I just missing anyething? Thanks again for yazi and your excellent work! |
Hi @Brixy, could you please paste your opener configuration here, and the steps you followed? This will help me understand what happened. |
It may be worth adding more information to the --version flag to figure out specifically which build is currently being executed. |
Just confirmed working on 492929a. in my flake.nix inputs: yazi.url = "github:sxyazi/yazi"; in my flake.lock (just verifying version number):
in my home-manager.nix: programs.yazi = {
enable = true;
package = inputs.yazi.packages.${pkgs.system}.yazi;
enableFishIntegration = true;
settings = {
manager = {
sort_by = "natural";
sort_reverse = false;
sort_dir_first = true;
show_hidden = false;
show_symlink = true;
};
opener = {
audio = [{
exec = "clapper \"$@\"";
orphan = true;
}];
video = [{
exec = "clapper \"$@\"";
orphan = true;
}];
folder = [{
exec = "$EDITOR \"$@\"";
block = true;
}];
text = [{
exec = "$EDITOR \"$@\"";
block = true;
}];
fallback = [
{
exec = "xdg-open \"$@\"";
orphan = true;
}
{
exec = "$EDITOR \"$@\"";
block = true;
}
];
};
};
}; which generates the following ~/.config/yazi/yazi.toml file: [manager]
show_hidden = false
show_symlink = true
sort_by = "natural"
sort_dir_first = true
sort_reverse = false
[opener]
[[opener.audio]]
exec = "clapper \"$@\""
orphan = true
[[opener.fallback]]
exec = "xdg-open \"$@\""
orphan = true
[[opener.fallback]]
block = true
exec = "$EDITOR \"$@\""
[[opener.folder]]
block = true
exec = "$EDITOR \"$@\""
[[opener.text]]
block = true
exec = "$EDITOR \"$@\""
[[opener.video]]
exec = "clapper \"$@\""
orphan = true |
Thanks a lot for your replies! Here’s my steps to reproduce: I just deleted my Moreover, I switched back to the default settings and just edited a single line for the
When I open a video it seems to be run as a child process anyway, and it is listed in the list of tasks ( As soon as yazi is closed ( Thanks a lot for investigating! BTW: Just noticed that |
I followed the steps above to reproduce the issue and found that the reason is that It retrieves Although |
Seems like this is what #206 to do |
Excellent. Can confirm that #229 works perfectly—with So mpv was either the best or worst example ;-) Thank you very much for all your work! Just as a side note: When yazi is killed by just closing its window using the window manager (river) the mpv window is closed, too. That’s no problem at all. Yet, when an |
I've tried for a long time but couldn't fix it. I've decided to just leave it here. If anyone knows the reason, please let me know :)
I think what you're asked is the undo function in the Vi-like input component. https://yazi-rs.github.io/docs/usage/configuration/keymap#normal-mode |
Yes, sorry. I did not investigate here. I thought it was possible to e.g. undo file deletion or mass renaming.
Thank you very much for investigating!! |
Hi @Brixy, I have revisited it and found a solution. A PR is created should fix it: #290 |
Thank you very much for your brilliant work! I can confirm that this works. BTW: I found a use case where this is important: If you opened yazi ‘directly’ e.g. using the following command in a window manager, closing yazi using
With your changes everything works perfectly. Thanks a lot for this! |
I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
When opening a file (with "o") with a mimeapp (zathura or any other application), the resulting process is a child process of yazi. Closing yazi will also close the child process. It would be nice to pop into yazi, open a file, and close yazi without also closing the spawned process.
The text was updated successfully, but these errors were encountered: