-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add counter component to the header for displaying currently selected/yanked items #646
feat: add counter component to the header for displaying currently selected/yanked items #646
Conversation
Thank you for the PR! I just want to add an API to get the number of selected files, but I realized an issue - currently, the selection state is specific to the directory, meaning it can only get the selection state of the current directory. But it would make more sense to get all selected files for display. We will add support for selecting across directories in the future. So I need to do some refactoring to modify it to a tab-specific global selection state. I'll continue reviewing this PR after the refactoring is done :) |
Ah I didn't catch that actually. Best of luck then, we can come back to this later |
Would it be possible to write not only the number of selected/yanked items, but also the size of all selected items? |
That may be better as a plugin or at least a separate feature, @sxyazi what do you think? |
Yep it should work as a UI plugin and not included in this PR. |
40035fc
to
458ca3b
Compare
Should be ready for you to review when you have the time @sxyazi , pretty small PR |
Co-authored-by: 三咲雅 · Misaki Masa <[email protected]>
Co-authored-by: 三咲雅 · Misaki Masa <[email protected]>
Yep those changes seem good. I do also like hiding the tab component if there's only one. |
Alright, I think there are no more problems here, let us merge it! |
Thanks for the addition! I noticed a tiny issue. When you paste ( Yet, when you move files ( (Tested with original config files.) |
No description provided.