Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations for Lua #657

Closed
1 task
UtkarshVerma opened this issue Feb 11, 2024 · 4 comments
Closed
1 task

Type annotations for Lua #657

UtkarshVerma opened this issue Feb 11, 2024 · 4 comments
Labels
feature New feature request

Comments

@UtkarshVerma
Copy link

Is your feature request related to a problem? Please describe

When defining the configuration in Lua, I have to hop between my editor and the docs. Having type annotations for classes and functions in the code base would greatly help this.

For example, users can hover over the function or class and get up-to-date information about them through language servers like lua-language-server.

Will you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

The Neovim ecosystem has already embraced the LuaCATS annotations and it would fit in this project as well.

Describe alternatives you've considered

No response

Additional context

No response

@UtkarshVerma UtkarshVerma added the feature New feature request label Feb 11, 2024
@teto
Copy link

teto commented Feb 12, 2024

if sxyazi agrees, would you be ready to contribute those annotations ? I find them quite powerful in the neovim ecosystem

@sxyazi
Copy link
Owner

sxyazi commented Feb 13, 2024

I agree, this is a great improvement for plugin development experience, but I don't have enough time to maintain another set of type definitions besides documentation. I would be very grateful if someone is willing to help maintain them 🙏🏻

@sxyazi
Copy link
Owner

sxyazi commented Feb 17, 2024

Closing as not in the plan

@sxyazi sxyazi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

3 participants