fix: change the rust tool chain in shell.nix from stable to nightly
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Will these changes affect regular users? I've completely forgotten my Nix knowledge :D |
Note that the rust version is still stable in flake.nix which is used to build the provide the app via flake. The rustfmt.toml rules are only supported by rust nightly. With the current stable rust tool chain in flake.nix, `cargo fmt` gives me warnings like ``` Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = false`, unstable features are only available in n ``` The format result with those warnings is different from the current code base for almost all files. I guess the main contributors of the repo use nightly rust. If so, we should make it consistent in shell.nix to help other contributors onboard with the same env.
15cm
force-pushed
the
inconsistent-fmt-result
branch
from
e1b3853 to
647bda9
Compare
15cm
changed the title
|
Good point. I didn't realize you provide the package via flake as well (I fetch the package from nixpkg). I limited the stable->nightly to shell.nix which is only for dev shell. The content of flake.nix is untouched so the package is still built via stable rust and it won't affect end users. The diff of flake.nix is formatting only. |
|
Thank you! |
sxyazi
changed the title
shell.nix from stable to nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustfmt.toml rules are only supported by rust nightly. With the current stable rust tool chain in flake.nix,
cargo fmtgives me warnings likeThe format result with those warnings is different from the current code base for almost all files. I guess the main contributors of the repo use nightly rust. If so, we should make it consistent in shell.nix to help other contributors onboard with the same env.