Bugs noticed in a SingularityCE PR imported to Apptainer #3494
Labels
bug
Something isn't working
Comments
|
Thanks for the info @DrDaveD Much appreciated. |
dtrudg
added a commit
to dtrudg/singularity
that referenced
this issue
Feb 3, 2025
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected. Correct an incorrect debug message from copy/paste error. Fixes sylabs#3494
dtrudg
added a commit
to dtrudg/singularity
that referenced
this issue
Feb 3, 2025
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected. Correct an incorrect debug message from copy/paste error. Fixes sylabs#3494
dtrudg
added a commit
to dtrudg/singularity
that referenced
this issue
Feb 3, 2025
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected. Correct an incorrect debug message from copy/paste error. If the starter fails when starting an instance, output the starter StdErr to the terminal StdErr - previously we were writing started StdErr to terminal StdOut. Fixes sylabs#3494
dtrudg
added a commit
to dtrudg/singularity
that referenced
this issue
Feb 3, 2025
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected. Correct an incorrect debug message from copy/paste error. If the starter fails when starting an instance, output the starter StdErr to the terminal StdErr - previously we were writing started StdErr to terminal StdOut. Fixes sylabs#3494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FYI I noticed while working on apptainer/apptainer#2712 that
instanceDbusXdge2e tests added in cgroups: rework checks for cgroup support #2569 are missing a call toe2e.WithRootlessEnv()(or some other way of importing the default environment) and so never actually get the cgroups v2-relevant environment variables applied. The tests happen to pass because the first two only cause debug messages and the second two always print out warnings for both variables before failing.cgroups.IsCgroup2UnifiedModecheck inCanUseCgroups()is copy-pasted from the!systemdcheck, giving the wrong debug message for instances when cgroups v2 unified mode is not available.The text was updated successfully, but these errors were encountered: