Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag is not hidden correctly in the tag selector #31

Open
sylque opened this issue Sep 13, 2022 · 2 comments
Open

Tag is not hidden correctly in the tag selector #31

sylque opened this issue Sep 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@sylque
Copy link
Owner

sylque commented Sep 13, 2022 •
edited
Loading

When the discpage hide tags setting is unchecked, the discpage tags appear in the tag selector.
@sylque sylque added the bug Something isn't working label Sep 13, 2022
@sylque sylque changed the title The tag selector shows up where it shouldn't Tags are not hidden correctly in the tag selector Sep 13, 2022
@sylque
Copy link
Owner Author

sylque commented Sep 13, 2022

Partial fix in v1.0.51: discpage tags are hidden correctly in the tag chooser "selection" section and in the combo list.

However one issue remains: the current discpage tag still shows up in the main area.
image

This cannot be removed in CSS.

Beware when fixing this: when the discpage tag is the only selected tag, the main area needs to show the text "optional tags" instead of remaining empty.

sylque added a commit that referenced this issue Sep 13, 2022
@sylque
Partial fix for #31
ab820ce
@noobishme
Copy link

noobishme commented Sep 13, 2022 •
edited
Loading

Applying Upgrade to DiscPage v1.0.51 right now... and also Upgrading Discourse...

@sylque sylque changed the title Tags are not hidden correctly in the tag selector Tag is not hidden correctly in the tag selector Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylque @noobishme