New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple sample rates #271

Open

1 of 4 tasks

jmcker opened this issue Apr 25, 2019 · 0 comments

Member

jmcker commented Apr 25, 2019 •

edited

Loading

We only currently support 44,100 Hz (configured at compile time) and make some assumptions based on that.

Things to consider

If we record a file at X Hz and then play it back at Y Hz will libsndfile resample for us?
Switching sample rate during record or playback?
Size of ring buffer at higher sample rates. We allocate based on duration, but 2s of space at 48kHz is 1s at 96kHz.
Testing devices for supported sample rates and perhaps falling back to something on fail.

TODO

Replace use of SAMPLE_RATE macro with HulaSettings::getSampleRate()
Check all timing to ensure they account for a faster or slower sample rate
Add Controller API for retrieving HulaAudioSettings object or changing sample rate
Write test cases for different sample rates

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment