Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CSRMatrix #228

Open
FFroehlich opened this issue May 2, 2018 · 4 comments
Open

Support for CSRMatrix #228

FFroehlich opened this issue May 2, 2018 · 4 comments

Comments

@FFroehlich
Copy link

I am currently working on code that computes matrix-matrix products of large, sparse matrices (>1k rows/columns, similar number of non-zero entries), which is relatively slow (multiple hours per product). I assume that this could be computed much faster by storing these matrices in a sparse representation and computing the products using respective sparse routines. However, I could not find any support for the sparse matrix class CSRMatrix in this wrapper.

Is this already implemented and I simply did not look in the right place? Are there any plans to support CSRMatrix in this wrapper in the near future?

@FFroehlich FFroehlich changed the title Support for CSparseMatrix Support for CSRMatrix May 2, 2018
@bjodah
Copy link
Contributor

bjodah commented May 2, 2018

You're right that it is not yet exposed in this python wrapper. I believe it's simply due to no one having had the time / need for it up till now.

@FFroehlich
Copy link
Author

FFroehlich commented May 2, 2018

Do I correctly understand that implementation would simply require replicating

cdef cppclass DenseMatrix(MatrixBase):
and following and adapting it to the CSRMatrix class?

@bjodah
Copy link
Contributor

bjodah commented May 2, 2018

Yes, together with the corresponding adaptions in symengine_wrapper.pyx and adding a few tests to the test suite.

@laisnegautier
Copy link

Hi, will we see a bind for CSRMatrix soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants