Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub alerts #2

Closed
4 tasks done
nzakas opened this issue Oct 18, 2024 · 3 comments
Closed
4 tasks done

Support GitHub alerts #2

nzakas opened this issue Oct 18, 2024 · 3 comments
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on

Comments

@nzakas
Copy link

nzakas commented Oct 18, 2024

Initial checklist

Problem

GitHub added support for alerts at the end of 2023. This package doesn't currently parse this syntax.

Solution

Update mdast-util-gfm to support alerts.

Alternatives

Another approach would be to create a separate plugin just for alerts so anyone could mix it into their setup. However, it does seem like most people expect "GFM" to include alerts at this point.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 18, 2024
@remcohaszing
Copy link
Member

GitHub alerts are not a part of GFM. It’s an HTML transform. See rehypejs/rehype-github#3 and https://github.com/remarkjs/remark-gfm/issues?q=is:issue+alert.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024

This comment has been minimized.

@remcohaszing remcohaszing added 👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on labels Oct 18, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Oct 18, 2024

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants