Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation (1.5.4) #533

Open
annedrewhu opened this issue May 9, 2019 · 3 comments
Open

Add documentation (1.5.4) #533

annedrewhu opened this issue May 9, 2019 · 3 comments
Assignees

Comments

@annedrewhu
Copy link
Member

annedrewhu commented May 9, 2019

There's a lot of internal documentation that needs to be added. How do we decide where to start?

I had an idea that before every release we could write down which areas of the code we had to dive into and that we felt needed more documentation. This is kind of like "add it when you see it isn't there", but in a more structured form.

So, for 1.5.4 actually most of the documentation would need to be added by me, since I did the transition to LLVM 6. Here are some of the files that need to be better documented:

EDIT: The list of things to document will be in my review of the PR

  • LLVMModelGenerator.cpp
  • ModelDataIRBuilder.cpp
  • ModelGeneratorContext.h
  • ModelGeneratorContext.cpp
  • rrSparse.cpp
@annedrewhu annedrewhu added this to the 1.5.4 (LLVM 6) milestone May 9, 2019
@hsauro
Copy link

hsauro commented May 9, 2019 via email

@annedrewhu
Copy link
Member Author

Great, the LLVM stuff may be quite challenging at the start, so I will probably write this documentation myself, but the bird's eye view documentation is much needed.

@annedrewhu annedrewhu self-assigned this May 9, 2019
@annedrewhu
Copy link
Member Author

I'm doing a review on the PR, so that will be where I list all the things that need to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants