Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential optimization of LLVMExecutableModel::getReactionRates() #616

Open
evilnose opened this issue May 18, 2020 · 0 comments
Open

Potential optimization of LLVMExecutableModel::getReactionRates() #616

evilnose opened this issue May 18, 2020 · 0 comments

Comments

@evilnose
Copy link

The previous optimizations in LLVMExecutableModel::getReactionRates() attempt to not re-calculate reaction rates when they are updated. However, they fail to account for assignmentRules of boundary variables and would not re-calculate when in fact some variables have changed (see #610). Additionally the bug was present in reaction rates with only time as a variable. Therefore these optimizations are turned off for now (see commented out section in getReactionRates()).

A potential future optimization that is more robust, is to keep track if each variable is constant, and only re-calculate if a reaction has non-constant variables. Additionally, since a reaction rate may depend on another reaction, a table may be needed to keep track which reaction rates have been deemed constant. This should only be done once before each simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant