Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users reset species default values #789

Open
luciansmith opened this issue Jul 12, 2021 · 7 comments
Open

Let users reset species default values #789

luciansmith opened this issue Jul 12, 2021 · 7 comments

Comments

@luciansmith
Copy link

If the value of a species is not set, roadrunner gives it a default value of 0. Other simulators like Copasi give them a default value of 1!

There's no great way to resolve this, since a lot of extant roadrunner/tellurium models and examples rely on our existing default. So probably the best solution is:

  • Create a new user setting, and give it the default value of 'no default': make sure that users explicitly set the values for their species.
  • Allow users to set the species default value to 0 or 1, to match past-roadrunner or Copasi.
@matthiaskoenig
Copy link
Collaborator

These are invalid (underspecified) models if the species are used to calculate any depending math. Not sure it is a good idea to give any value beside NaN in roadrunner, because it hides obvious problems in the model.

@luciansmith
Copy link
Author

Yes, that's what I want the new default to be. However, roadrunner has provided defaults for years (as have other simulators) so it will cause problems if we suddenly remove that feature.

@hsauro
Copy link

hsauro commented Jul 12, 2021 via email

@matthiaskoenig
Copy link
Collaborator

@hsauro
But this is not a problem of roadrunner, but of the tool creating the SBML model (assumingly antimony?).
So the default should be 0 in antimony thereby creating valid models.

@hsauro
Copy link

hsauro commented Jul 12, 2021 via email

@luciansmith
Copy link
Author

Providing defaults is something that I've considered adding to antimony in the past, but haven't ever done. Wherever it was added, it wouldn't be too difficult to do.

@hsauro
Copy link

hsauro commented Jul 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants