Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR not displayed #35

Open
teicors opened this issue Oct 13, 2021 · 8 comments
Open

QR not displayed #35

teicors opened this issue Oct 13, 2021 · 8 comments

Comments

@teicors
Copy link

teicors commented Oct 13, 2021

Hi,
after the installation of your plugin, the qr code isn't displayed as the screen attached.
No error inside the log and moving the mouse over the "image" the cursor change from arrow to a different: in my opinion don't works the rendering of qr code.
The syspass-ap is the latest 3.2.2.
I added the line
- COMPOSER_EXTENSIONS=syspass/plugin-authenticator:^v2.2
into docker-compose.yml

I found the following lines during the update of the container:

1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Package jeremeamia/superclosure is abandoned, you should avoid using it. Use opis/closure instead.
Package fzaninotto/faker is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/dbunit is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.
Generating optimized autoload files
Class SP\Tests\SP\Services\UserGroup\UserToUserGroupServiceTest located in ./tests/SP/Services/UserGroup/UserToUserGroupServiceTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Services\UserGroup\UserGroupServiceTest located in ./tests/SP/Services/UserGroup/UserGroupServiceTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Services\User\UserServiceTest located in ./tests/SP/Services/User/UserServiceTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Services\UserProfile\UserProfileServiceTest located in ./tests/SP/Services/UserProfile/UserProfileServiceTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Services\UserPassRecover\UserPassRecoverServiceTest located in ./tests/SP/Services/UserPassRecover/UserPassRecoverServiceTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Repositories\UserToUserGroupRepositoryTest located in ./tests/SP/Repositories/UserToUserGroupRepositoryTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\Repositories\UserGroupRepositoryTestCase located in ./tests/SP/Repositories/UserGroupRepositoryTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Util\UtilTest located in ./tests/SP/Util/UtilTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Core\Acl\AclTest located in ./tests/SP/Core/Acl/AclTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Core\Crypt\SecureKeyCookieTest located in ./tests/SP/Core/Crypt/SecureKeyCookieTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Core\Crypt\HashTest located in ./tests/SP/Core/Crypt/HashTest.php does not comply with psr-4 autoloading standard. Skipping.
Class SP\Tests\SP\Core\Crypt\CryptPKITest located in ./tests/SP/Core/Crypt/CryptPKITest.php does not comply with psr-4 autoloading standard. Skipping.

error_syspass

@josuealcalde
Copy link

It seems the new SVG rendered introduced by the new version of bacon/qr-code is not working well.
It generates an SVG but it seems it is not correct and it renders empty.

@josuealcalde
Copy link

This is an example of SVG generated which is render as a white box:

<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="200" height="200" viewBox="0 0 200 200"><rect x="0" y="0" width="200" height="200" fill="#fefefe"/><g transform="scale(4,444)"><g transform="translate(4,4)"><path fill-rule="evenodd" d="M9 0L9 1L8 1L8 2L9 2L9 3L8 3L8 4L10 4L10 7L11 7L11 4L12 4L12 5L13 5L13 6L12 6L12 9L13 9L13 8L14 8L14 9L15 9L15 10L17 10L17 11L16 11L16 12L17 12L17 13L18 13L18 12L17 12L17 11L19 11L19 13L20 13L20 15L19 15L19 14L16 14L16 13L12 13L12 11L13 11L13 10L11 10L11 13L10 13L10 12L9 12L9 10L6 10L6 11L5 11L5 12L4 12L4 10L5 10L5 8L0 8L0 9L4 9L4 10L3 10L3 12L2 12L2 14L3 14L3 13L4 13L4 15L2 15L2 16L1 16L1 15L0 15L0 16L1 16L1 17L0 17L0 18L1 18L1 19L0 19L0 20L1 20L1 25L0 25L0 29L1 29L1 26L2 26L2 27L4 27L4 26L5 26L5 29L8 29L8 31L9 31L9 32L8 32L8 37L9 37L9 33L10 33L10 36L11 36L11 37L12 37L12 35L13 35L13 34L11 34L11 32L10 32L10 30L9 30L9 29L8 29L8 28L6 28L6 27L7 27L7 26L6 26L6 25L9 25L9 27L10 27L10 25L9 25L9 24L6 24L6 25L3 25L3 24L4 24L4 23L7 23L7 22L8 22L8 23L9 23L9 21L8 21L8 20L6 20L6 21L7 21L7 22L5 22L5 21L4 21L4 20L3 20L3 18L4 18L4 17L5 17L5 19L8 19L8 18L6 18L6 17L9 17L9 18L10 18L10 19L11 19L11 20L10 20L10 24L11 24L11 21L12 21L12 22L13 22L13 23L12 23L12 25L13 25L13 24L14 24L14 25L16 25L16 26L15 26L15 27L14 27L14 28L15 28L15 29L12 29L12 27L13 27L13 26L11 26L11 28L10 28L10 29L12 29L12 30L13 30L13 31L12 31L12 33L13 33L13 32L14 32L14 33L16 33L16 34L15 34L15 35L14 35L14 36L16 36L16 37L18 37L18 36L16 36L16 35L19 35L19 36L20 36L20 35L19 35L19 34L17 34L17 33L18 33L18 32L14 32L14 31L17 31L17 30L18 30L18 29L19 29L19 28L21 28L21 29L20 29L20 31L19 31L19 32L22 32L22 31L23 31L23 30L24 30L24 31L26 31L26 32L24 32L24 33L20 33L20 34L24 34L24 35L25 35L25 34L24 34L24 33L29 33L29 34L27 34L27 35L26 35L26 36L23 36L23 35L21 35L21 37L27 37L27 35L28 35L28 36L29 36L29 37L30 37L30 36L31 36L31 37L32 37L32 36L31 36L31 35L32 35L32 34L33 34L33 33L34 33L34 35L36 35L36 36L34 36L34 37L37 37L37 32L36 32L36 31L37 31L37 30L35 30L35 32L33 32L33 31L34 31L34 30L33 30L33 28L24 28L24 29L23 29L23 27L19 27L19 26L17 26L17 25L18 25L18 24L17 24L17 25L16 25L16 23L17 23L17 21L18 21L18 22L19 22L19 21L18 21L18 20L15 20L15 19L17 19L17 17L18 17L18 16L14 16L14 15L19 15L19 16L20 16L20 15L21 15L21 17L20 17L20 19L19 19L19 20L20 20L20 22L22 22L22 23L21 23L21 24L20 24L20 23L19 23L19 24L20 24L20 26L21 26L21 25L23 25L23 26L26 26L26 27L29 27L29 26L30 26L30 25L31 25L31 24L32 24L32 25L34 25L34 27L35 27L35 28L34 28L34 29L36 29L36 27L37 27L37 26L36 26L36 25L37 25L37 22L36 22L36 21L37 21L37 18L35 18L35 16L36 16L36 17L37 17L37 14L36 14L36 13L37 13L37 10L36 10L36 8L35 8L35 12L31 12L31 11L34 11L34 10L32 10L32 8L31 8L31 9L30 9L30 8L29 8L29 4L28 4L28 5L27 5L27 2L28 2L28 1L29 1L29 0L28 0L28 1L26 1L26 0L25 0L25 2L26 2L26 3L24 3L24 4L22 4L22 5L21 5L21 3L22 3L22 2L23 2L23 1L24 1L24 0L21 0L21 2L20 2L20 5L21 5L21 6L20 6L20 7L19 7L19 4L18 4L18 3L19 3L19 2L18 2L18 1L20 1L20 0L18 0L18 1L17 1L17 0L15 0L15 1L17 1L17 2L16 2L16 4L12 4L12 2L13 2L13 1L11 1L11 2L10 2L10 0ZM14 2L14 3L15 3L15 2ZM17 2L17 3L18 3L18 2ZM10 3L10 4L11 4L11 3ZM16 4L16 5L17 5L17 7L16 7L16 6L15 6L15 7L14 7L14 6L13 6L13 7L14 7L14 8L15 8L15 7L16 7L16 9L17 9L17 10L19 10L19 11L20 11L20 12L21 12L21 10L23 10L23 11L25 11L25 12L26 12L26 9L25 9L25 8L26 8L26 6L27 6L27 10L29 10L29 11L27 11L27 12L30 12L30 10L29 10L29 8L28 8L28 6L27 6L27 5L26 5L26 4L24 4L24 5L23 5L23 7L24 7L24 5L26 5L26 6L25 6L25 8L23 8L23 9L21 9L21 7L22 7L22 6L21 6L21 7L20 7L20 8L19 8L19 7L18 7L18 5L17 5L17 4ZM8 5L8 7L9 7L9 5ZM6 8L6 9L11 9L11 8ZM17 8L17 9L18 9L18 8ZM33 8L33 9L34 9L34 8ZM20 9L20 10L21 10L21 9ZM23 9L23 10L24 10L24 9ZM1 10L1 11L2 11L2 10ZM6 11L6 12L8 12L8 11ZM14 11L14 12L15 12L15 11ZM23 12L23 13L24 13L24 14L22 14L22 13L21 13L21 14L22 14L22 15L23 15L23 17L24 17L24 18L22 18L22 17L21 17L21 19L22 19L22 20L23 20L23 21L22 21L22 22L23 22L23 23L24 23L24 25L25 25L25 24L26 24L26 23L27 23L27 22L28 22L28 24L29 24L29 25L30 25L30 24L31 24L31 23L30 23L30 22L31 22L31 21L30 21L30 22L28 22L28 21L29 21L29 19L30 19L30 20L33 20L33 19L30 19L30 18L31 18L31 17L30 17L30 18L29 18L29 19L28 19L28 21L25 21L25 20L27 20L27 19L25 19L25 17L24 17L24 16L26 16L26 18L28 18L28 17L27 17L27 16L29 16L29 15L30 15L30 14L31 14L31 13L29 13L29 15L27 15L27 16L26 16L26 14L28 14L28 13L24 13L24 12ZM0 13L0 14L1 14L1 13ZM5 13L5 15L4 15L4 16L5 16L5 17L6 17L6 16L9 16L9 17L10 17L10 16L11 16L11 18L13 18L13 19L12 19L12 21L15 21L15 22L16 22L16 21L15 21L15 20L14 20L14 19L15 19L15 18L16 18L16 17L14 17L14 16L13 16L13 17L12 17L12 15L13 15L13 14L12 14L12 13L11 13L11 14L9 14L9 13ZM32 13L32 15L31 15L31 16L32 16L32 15L33 15L33 13ZM6 14L6 15L8 15L8 14ZM34 14L34 16L33 16L33 17L32 17L32 18L33 18L33 17L34 17L34 16L35 16L35 14ZM2 16L2 17L1 17L1 18L2 18L2 17L3 17L3 16ZM1 19L1 20L2 20L2 19ZM23 19L23 20L25 20L25 19ZM34 19L34 20L35 20L35 21L36 21L36 19ZM2 21L2 22L3 22L3 23L2 23L2 24L3 24L3 23L4 23L4 22L3 22L3 21ZM23 21L23 22L24 22L24 21ZM32 21L32 22L33 22L33 23L34 23L34 24L36 24L36 23L34 23L34 21ZM14 23L14 24L15 24L15 23ZM29 23L29 24L30 24L30 23ZM2 25L2 26L3 26L3 25ZM26 25L26 26L28 26L28 25ZM16 26L16 28L18 28L18 27L17 27L17 26ZM2 28L2 29L4 29L4 28ZM21 29L21 31L22 31L22 30L23 30L23 29ZM24 29L24 30L26 30L26 31L27 31L27 32L28 32L28 29ZM29 29L29 32L32 32L32 29ZM30 30L30 31L31 31L31 30ZM35 32L35 33L36 33L36 32ZM30 34L30 35L29 35L29 36L30 36L30 35L31 35L31 34ZM0 0L0 7L7 7L7 0ZM1 1L1 6L6 6L6 1ZM2 2L2 5L5 5L5 2ZM30 0L30 7L37 7L37 0ZM31 1L31 6L36 6L36 1ZM32 2L32 5L35 5L35 2ZM0 30L0 37L7 37L7 30ZM1 31L1 36L6 36L6 31ZM2 32L2 35L5 35L5 32Z" fill="#000000"/></g></g></svg>

@josuealcalde
Copy link

josuealcalde commented Oct 18, 2021

I need a quick solution, so I have made a fork and a release with the last 2.2.3 changes undone.
I have downgraded bacon-qr to 1.0 and it works again.

josuealcalde@526be04
https://github.com/josuealcalde/plugin-Authenticator/releases/tag/v2.2.2%2Bjosuealcalde.1

A better solution would be to make SVG rendered work.

@teicors
Copy link
Author

teicors commented Oct 18, 2021

The issue is related to the language: I found the error with the Italian language, but switching to English the QR code is displayed well.

@vmario89
Copy link
Contributor

vmario89 commented Jun 5, 2022

this issue is still present. figured it out when installing a new instance of syspass

@fredddy255f
Copy link

hello, same issue with french language : no QR code displayed. QR code is displayed if switching to english.

@PatxiAndueza
Copy link

PatxiAndueza commented Aug 31, 2022

Is there any update in this topic?

Catalá, Deutsh, Español, Français, Magnyar, Italiano, Nederlands, Polski, Português and Rusian are not displaying the QR code. The rest of languages works propertly.

Tested with plugin versión 2.2.2 and sysPass version 3.2.11-php7.4, installed with docker-compose over Debian 11.

@vmario89
Copy link
Contributor

vmario89 commented Aug 31, 2022

hi. The qr code does not work for ALL languages except english, in short. As this bugs me too i had a look into that issue now and i found a solultion at the repository of the QR Code library itself: Bacon/BaconQrCode@fd4a877

in sysPass we can do the following file change and voila, it works:

cd vendor/bacon/bacon-qr-code/src/Renderer/Image
mv SvgImageBackEnd.php SvgImageBackEnd.php.bup
wget https://raw.githubusercontent.com/Bacon/BaconQrCode/fd4a87759f06e77fca038935008efea92731a0a6/src/Renderer/Image/SvgImageBackEnd.php

its a pitty that this pull request was not merged yet. For sysPass we could fork that library as a new git repo and reconfigure composer.json to install from another github source

btw there is also another PR for sysPass authenticator #36 but this did not work for me. Dont know why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants