Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance list is completely broken #484

Open
6 tasks done
mcarbonne opened this issue Jan 19, 2025 · 1 comment · May be fixed by #508
Open
6 tasks done

Maintenance list is completely broken #484

mcarbonne opened this issue Jan 19, 2025 · 1 comment · May be fixed by #508
Labels
🕷️ bug Something isn't working

Comments

@mcarbonne
Copy link
Contributor

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • I can replicate the issue inside the Demo install.

Homebox Version

main (a1dabaa)

What is the issue you are experiencing?

I recently updated my homebox instance with the latest changes and since the update, maintenance list is completely broken: filters do not work anymore as expected. When selecting "Completed", it show me some entries which are only scheduled (without any completion date).

I first thought it was related to #367 but after reverting this PR from my fork, the issue is still there.
I had a look directly in the database and I have a mix of different date formats (with and without timezone):

Image

There was also a change regarding date handling (&_time_format=sqlite added everywhere).
I'm still digging to find the change responsible for the bug.

How can the maintainer reproduce the issue?

For now, the way to reproduce the issue is to upgrade a running instance to a newer version.

Deployment

Docker (Linux)

OS Architechture

x86_64 (AMD, Intel)

Deployment Details

No response
@mcarbonne mcarbonne added the 🕷️ bug Something isn't working label Jan 19, 2025
@mcarbonne mcarbonne mentioned this issue Jan 19, 2025
Merged
@mcarbonne
Copy link
Contributor Author

mcarbonne commented Jan 19, 2025 •
edited
Loading

I found the commit responsible for the database issue: 1a4e98a. (#430)
I'm still investigating to check if this is responsible for all the other bugs or not.

EDIT: after reverting this commit in my fork, all issues are gone. Maybe PR #430 is totally fine on a new fresh database, but for sure a migration script would be required for already running instances.

@katosdev katosdev mentioned this issue Jan 25, 2025
Closed
@tankerkiller125 tankerkiller125 linked a pull request Feb 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕷️ bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for the Timestamp issue sysadminsmedia/homebox
1 participant
@mcarbonne