From 89adbfe9a533b9920783812c56fdbf06bcd1722c Mon Sep 17 00:00:00 2001
From: Matthias Baur <m.baur@syseleven.de>
Date: Fri, 13 Dec 2024 14:58:24 +0100
Subject: [PATCH] Remove SSH connection test since Gitlab Runner provides this
 feature already

Gitlab Runner already provides this feature with the config option
runners.autoscaler.instance_ready_command. Let's remove it to have fewer
code an faster connections.

See https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersautoscaler-section
---
 provider.go | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/provider.go b/provider.go
index 65b8bdf..6e3b370 100644
--- a/provider.go
+++ b/provider.go
@@ -1,7 +1,6 @@
 package fpoc
 
 import (
-	"bytes"
 	"context"
 	"errors"
 	"fmt"
@@ -14,7 +13,6 @@ import (
 	"github.com/jinzhu/copier"
 	"github.com/sardinasystems/fleeting-plugin-openstack/internal/openstackclient"
 
-	"gitlab.com/gitlab-org/fleeting/fleeting/connector"
 	"gitlab.com/gitlab-org/fleeting/fleeting/provider"
 )
 
@@ -320,28 +318,6 @@ func (g *InstanceGroup) ConnectInfo(ctx context.Context, instanceID string) (pro
 		info.Arch = "amd64"
 	}
 
-	// g.log.Debug("Info", "info", info)
-
-	inp := bytes.NewBuffer(nil)
-	combinedOut := bytes.NewBuffer(nil)
-
-	ropts := connector.ConnectorOptions{
-		DialOptions: connector.DialOptions{
-			// UseExternalAddr: true,
-		},
-		RunOptions: connector.RunOptions{
-			Command: `echo "ok"`,
-			Stdin:   inp,
-			Stdout:  combinedOut,
-			Stderr:  combinedOut,
-		},
-	}
-	err = connector.Run(ctx, info, ropts)
-	if err != nil {
-		return provider.ConnectInfo{}, fmt.Errorf("Failed to test ssh: %w", err)
-	}
-	g.log.Debug("SSH test result", "out", combinedOut.String())
-
 	return info, nil
 }