-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is it possible to support prevent_deletion flag in the provider #50
Comments
@stefanandres It looks like lifecycle attributes supported by default. For the case we talked about, you would need to add
into Note that the message
means that resource was not found on the "server" during state refresh, therefore assumed to be deleted. Here terraform will try to just "forget" the resource, therefore adding lifecycle.prevent_destroy=true for such cases will not affect provider's behavior because it does not destroy the resource as such. |
Just stumbled over this in https://code.syseleven.de/syseleven/metakube/terraform-module-metakube/-/blob/acdbde6b1814365e445ac86c8344a45d8604bba7/cluster.tf#L44. The problem is that we cannot use lifecycle.prevent_destroy in the module because there is no way to make it configurable by module variables. -> hashicorp/terraform#18367 The idea is, that the provider supports this itself. Do you think that this is reasonable? |
@furkhat What do you think? :) |
@baurmatt |
@furkhat The cluster and node deployment resources would be fine. We want to ensure that it's not irreversible destroyed/recreated because of an unplanned/unseen change. |
The text was updated successfully, but these errors were encountered: