Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename negative_ttl into default_ttl #39

Merged
merged 2 commits into from
May 15, 2022

Conversation

ulvida
Copy link
Contributor

@ulvida ulvida commented May 8, 2022

Hi! When I proposed the so called "dynamic" zones management (I think we should rather say raw zones and yaml zones, for instance), I did a mistake naming negative_ttl variable:

$TTL {{ zone.negative_ttl|default('3600') }} ; 1 hour

In fact, this value defines the $TTL BIND macro, which defines the default ttl for Ressource Records that don't have a specific TTL defined.
I also detailed a little bit the README doc.

Copy link
Contributor

@t2d t2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. The addition to the README will make it much more easy to understand. I'm not sure the renaming of negative_ttl to default_ttl is really necessary. Negative TTL seems to be the technically correct term.

README.md Outdated Show resolved Hide resolved
@ulvida
Copy link
Contributor Author

ulvida commented May 13, 2022

FYI: we have a bigger PR in the pipe, that we are first testing ourselves with our DNS.

@t2d t2d merged commit d8d1090 into systemli:main May 15, 2022
@t2d
Copy link
Contributor

t2d commented May 15, 2022

cool, thanks!

0x46616c6b pushed a commit that referenced this pull request Jun 19, 2022
* Rename negative_ttl into default_ttl

Co-authored-by: t2d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants