Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Argument Types Use Show Instances That Render Them Invalid #29

Open
KirinDave opened this issue Jun 20, 2019 · 0 comments
Open

Some Argument Types Use Show Instances That Render Them Invalid #29

KirinDave opened this issue Jun 20, 2019 · 0 comments

Comments

@KirinDave
Copy link
Contributor

KirinDave commented Jun 20, 2019 •
edited
Loading

StatusIds, NotificationIds and AccountIds are using a default show instance to render to the API. This means that all GET calls for notifications will not be able to use the "in_reply_to_id" or the "since_id" features.

These probably require a unique instance in their argument type. I've been patching it with instances like this:

instance Show StatusId where
  show = unStatusId

However, this is really not the best option as it makes debugging worse.
KirinDave added a commit to KirinDave/hastodon that referenced this issue Jun 20, 2019
@KirinDave
Fixing Issues syucream#29, syucream#30, syucream#31 and others.
1761ad7 
This is a very incomplete fix but does make the
library immediately usable, whereas right now
it will fail on every API call I've tried.
@KirinDave KirinDave mentioned this issue Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KirinDave