Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some data not parsing from the json #125

Open
shmuel44 opened this issue May 25, 2023 · 3 comments
Open

Some data not parsing from the json #125

shmuel44 opened this issue May 25, 2023 · 3 comments

Comments

@shmuel44
Copy link

If the package on PyPI uses Pyproject.toml, then the name of the author appears in the author_email key, so, the JSON looks as follows:

{"info":{"author":"","author_email":"JanikCodes <[email protected]>", etc'

example

It looks like this if they're using setup.py

{"info":{"author":"Luca Cappelletti","author_email":"[email protected]", etc'

example

So, there are two cases that need to be parsed

@shmuel44 shmuel44 changed the title Some data not parsing from thr json Some data not parsing from the json May 25, 2023
@rizahmeds
Copy link

rizahmeds commented May 25, 2023

@shmuel44 Thanks for pointing out this.
@szabgab I am interested to work on this issue. As i can see we need to parse info['author_email'] appropriately before assigning it to self.entry[field] = info[field].
https://github.com/szabgab/pydigger.com/blob/main/PyDigger/fetch.py#L145

@shmuel44
Copy link
Author

It appears that there are a few more keys that aren't parsing correctly, the Homepage appears to be one of them, but I'm not certain, I will look again...

@rizahmeds
Copy link

rizahmeds commented May 28, 2023

@shmuel44 it would be good to have a test case to check the parsing result.
I am checking if test case is already there or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants