You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current reconciliation logic is confusing and might cause confusion. Among the 4 possible combinations of robot and project annotation existence, which are:
robot not exist, project not exist
robot not exist, project exist
robot exist, project not exist
robot exist, project exist
Case 2, 3 are invalid. For case 1, we need to automatically create harbor project and robot account, and for case 4, we need check whether these information are valid in harbor. It's overly complicated for PSB as it should be solely focusing on secret binding.
Proposing to move the annotation validation logic to namespace controller and making robot and project required field for PSB object. Namespace controller should validate or create corresponding resources, and create PSB with validated configurations. For PSB, it should always assume that the project and robot in its spec exists in harbor.
The text was updated successfully, but these errors were encountered:
The current reconciliation logic is confusing and might cause confusion. Among the 4 possible combinations of
robot
andproject
annotation existence, which are:robot
not exist,project
not existrobot
not exist,project
existrobot
exist,project
not existrobot
exist,project
existCase 2, 3 are invalid. For case 1, we need to automatically create harbor
project
androbot
account, and for case 4, we need check whether these information are valid in harbor. It's overly complicated for PSB as it should be solely focusing on secret binding.Proposing to move the annotation validation logic to namespace controller and making
robot
andproject
required field for PSB object. Namespace controller should validate or create corresponding resources, and create PSB with validated configurations. For PSB, it should always assume that theproject
androbot
in its spec exists in harbor.The text was updated successfully, but these errors were encountered: