Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project and robot as required in PSB #19

Open
hanlins opened this issue Apr 16, 2021 · 0 comments
Open

Make project and robot as required in PSB #19

hanlins opened this issue Apr 16, 2021 · 0 comments

Comments

@hanlins
Copy link
Collaborator

hanlins commented Apr 16, 2021

The current reconciliation logic is confusing and might cause confusion. Among the 4 possible combinations of robot and project annotation existence, which are:

  1. robot not exist, project not exist
  2. robot not exist, project exist
  3. robot exist, project not exist
  4. robot exist, project exist

Case 2, 3 are invalid. For case 1, we need to automatically create harbor project and robot account, and for case 4, we need check whether these information are valid in harbor. It's overly complicated for PSB as it should be solely focusing on secret binding.

Proposing to move the annotation validation logic to namespace controller and making robot and project required field for PSB object. Namespace controller should validate or create corresponding resources, and create PSB with validated configurations. For PSB, it should always assume that the project and robot in its spec exists in harbor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant