Wrong timeout used for federated media requests?

[syldrathecat]

Hi, I noticed this code here uses Config.TimeoutSeconds.UrlPreviews instead of Config.TimeoutSeconds.Federation:

matrix-media-repo/matrix/requests.go

Line 167 in 8a642d5

client.Timeout = time.Duration(ctx.Config.TimeoutSeconds.UrlPreviews) * time.Second

I believe this means that federated media downloads, by default, will be using the urlPreviewTimeoutSeconds (10 seconds) config value, instead of the federationTimeoutSeconds (2 minutes) value?

Thanks and sorry if I'm misunderstanding ^^

[turt2live]

indeed, yes. This was fixed in MMR v1.3.8 as part of GHSA-r6jg-jfv6-2fjv