Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoredHosts check skipped when unauthenticated #626

Closed
syldrathecat opened this issue Nov 20, 2024 · 0 comments · Fixed by #630
Closed

ignoredHosts check skipped when unauthenticated #626

syldrathecat opened this issue Nov 20, 2024 · 0 comments · Fixed by #630
Labels
access control bug

Comments

@syldrathecat
Copy link

syldrathecat commented Nov 20, 2024 •
edited
Loading

Hi,

It appears that the hosts listed under "ignoredHosts" are not checked when accessing unauthenticated media endpoints.

It looks like the bug was introduced in these two changes:

The check for IsHostIgnored is only performed when auth.User.UserId != ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
access control bug
Projects
v1.3 feature cycle
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ignoredHosts t2bot/matrix-media-repo
2 participants
@turt2live @syldrathecat