Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jumbotron with class ration instead of {config.jumbotron.class} #409

Open
mbsued opened this issue Oct 7, 2024 · 6 comments
Open

jumbotron with class ration instead of {config.jumbotron.class} #409

mbsued opened this issue Oct 7, 2024 · 6 comments

Comments

@mbsued
Copy link

mbsued commented Oct 7, 2024

With Version 5.3.16 there is now the class "ratio" in the jumbotron. The definded class in {config.jumbotron.class} has disappeared. So the content after the jumbotron is over it.

@CarstenHager
Copy link
Contributor

I have the same problem

t3solution added a commit that referenced this issue Oct 7, 2024
@mbsued
Copy link
Author

mbsued commented Oct 7, 2024

the mistake happens in the configProcessor at Line 527 in the else path
if ($hasBgImages && empty($currentPage['tx_t3sbootstrap_fullheightsection']) && !empty($processedRecordVariables['jumbotronBgimageratio'])) { $processedData['config']['jumbotron']['noBgRatio'] = false; $processedData['config']['jumbotron']['class'] .= ' ratio ratio-'.$processedRecordVariables['jumbotronBgimageratio']; $ratioArr = explode('x', $processedRecordVariables['jumbotronBgimageratio']); $x = $processedRecordVariables['jumbotronBgimageratio']; $y = $ratioArr[1].' / '.$ratioArr[0].' * 100%'; $processedData['ratioCalcCss'] = '.ratio-'.$x.'{--bs-aspect-ratio:calc('.$y.');}'; } else { $processedData['config']['jumbotron']['class'] = ' ratio'; }

@t3solution
Copy link
Owner

have you cleared the cache?

@mbsued
Copy link
Author

mbsued commented Oct 7, 2024

sorry seen to late that you solved the problem, only wanted to help :)

@t3solution
Copy link
Owner

thanks to you

@mbsued
Copy link
Author

mbsued commented Oct 7, 2024

Thanks for your work. t3sbootstrap is great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants