Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter the config to pass a --quiet-deps flag #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jukra
Copy link

@jukra jukra commented Sep 24, 2024

Adding an option to silence the deprecation warning during compilation.
https://sass-lang.com/documentation/cli/dart-sass/#:~:text=scss%20style.css-,%2D%2Dquiet%2Ddeps,rule%20or%20the%20%40debug%20rule.

This should fix #25 and kind of a workaround for #26

@nimmolo
Copy link

nimmolo commented Sep 26, 2024

@jukra It does work! Nevermind my above post. I forgot to add the config! 🫢

config.sass.quiet_deps = true

I deleted my above comment, although you may still receive it in email. Thank you again!

Deprecation warnings are still given for the top level scss files, as expected. But for the dozens of dependencies, no.

@jukra
Copy link
Author

jukra commented Sep 27, 2024

That's great, thanks for testing! @johnnyshields would you have time to review the PR?

@matiasmasca
Copy link

Could you please check this PR. We need it for our testing environment.

@perrro
Copy link

perrro commented Nov 7, 2024

People, we need this fix, the amount of warnings in the testing console is annoying 😵

@nimmolo
Copy link

nimmolo commented Nov 7, 2024

@perrro @matiasmasca I'm sure you know, but in the meantime, you can install the version from this branch in your Gemfile:

gem "dartsass-sprockets", git: "git://github.com/jukra/dartsass-sprockets.git", branch: "quiet-deps"

@matiasmasca
Copy link

@perrro @matiasmasca I'm sure you know, but in the meantime, you can install the version from this branch in your Gemfile:

gem "dartsass-sprockets", git: "git://github.com/jukra/dartsass-sprockets.git", branch: "quiet-deps"

Thank you! I will do that in the meantime

@matiasmasca
Copy link

It didn't work, for my case, I'm still getting the annoying warning messages in my test environment.

Before using it, I changed a little typo in @nimmolo recommendation 'quiet_deps' with "_"
gem "dartsass-sprockets", git: "git://github.com/jukra/dartsass-sprockets.git", branch: "quiet_deps"

@jukra
Copy link
Author

jukra commented Nov 15, 2024

It didn't work, for my case, I'm still getting the annoying warning messages in my test environment.

Before using it, I changed a little typo in @nimmolo recommendation 'quiet_deps' with "_" gem "dartsass-sprockets", git: "git://github.com/jukra/dartsass-sprockets.git", branch: "quiet_deps"

@matiasmasca did you also change your config?

# config/environments/development.rb
config.sass.quiet_deps = true

@rocket-turtle
Copy link

Checked it out and it works.

https://sass-lang.com/documentation/cli/dart-sass/#silence-deprecation

The --silence-deprecation= would also be really nice to have.

@nimmolo
Copy link

nimmolo commented Dec 1, 2024

@johnnyshields LGTM please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter the config to pass a --quiet-deps flag
5 participants