Update func_general.sh #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentiumoverdrive
commented
Jan 14, 2021
pentiumoverdrive
commented
- Added sudo to check repo function and using tee instead of ">>"
- The script is missing the "git" dependency, which made it impossible to install tacasgui on a clean ubuntu 18 install.
- The script is missing the "software-properties-common" dependency, which made it impossible to install php (since it needs add-apt-repository installed). Only an obsolete package is included in the script.
- Add sudo before mysql install so this can be installed as non-root as everything else using sudo.
* Added sudo to check repo function and using tee instead of ">>" * The script is missing the "git" dependency, which made it impossible to install tacasgui on a clean ubuntu 18 install. * The script is missing the "software-properties-common" dependency, which made it impossible to install php (since it needs add-apt-repository installed). Only an obsolete package is included in the script. * Add sudo before mysql install so this can be installed as non-root as everything else using sudo.
|
There are lots of inconsistency regarding sudo. It appears that you wouldn't run the script as root since the script relies on sudo in ~50% of the times and compose tells you not to run as root. So half of the stuff fails running as non root since its missing the sudo commmand. Whats is your recommended way to install this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.