Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PunyInform source formatting #8

Open
fredrikr opened this issue Nov 11, 2024 · 3 comments
Open

PunyInform source formatting #8

fredrikr opened this issue Nov 11, 2024 · 3 comments

Comments

@fredrikr
Copy link
Contributor

Glad to find this project. I submitted a PR for fixing problems in the PunyInform version.

The source for the PunyInform version has some pretty bad formatting. I'd be happy to fix it if you want.

I would also suggest to change the library structure, since neither Inform 6 or PunyInform is really related to Inform 7 (except in a very technical way, which doesn't matter to regular users - Inform 7 code is typically compiled to Inform 6 code, which is then compiled to Glulx code, but no one looks at the Inform 6 code.

Also, I find that you don't actually have Inform 7 source. I think someone who knows Inform 7 would produce this for you in half an hour. This is quite interesting to include, as the language is so very different.

So for the directory structure I suggest either:
``´

  • Inform 7
  • Inform 6
  • PunyInform
or:
  • Inform 7
  • Inform 6
    • Inform6lib
    • PunyInform

@fredrikr
Copy link
Contributor Author

Sorry, you do have an Inform 7 version! I mistook it for an ini file [:)]

@taciano-perez
Copy link
Owner

Hi @fredrikr, thanks for your contributions. The Inform and Adventuron versions were made by @nateProjects. I'm happy to merge the PRs, but I can't meaningfully review them. Maybe a good idea to add @nateProjects as reviewer for future PRs?

@fredrikr
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants