Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs test CI always run, even for cases where nothing inside /docs folder was touched #2532

Closed
novusnota opened this issue Mar 28, 2025 · 0 comments · Fixed by #2533
Closed
Assignees
Labels
kind: docs Documentation for docs.tact-lang.org kept in docs folder scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky)
Milestone

Comments

@novusnota
Copy link
Member

That's because the Cookbook checks now depend on the repo version of the compiler and not on the one installed in npm.

Therefore, some code samples might start breaking all of a sudden, so it's better to always run docs CI, especially considering that it takes no more than 2 minutes, usually less.

The problem was discovered in #2529, but introduced in another PR, which didn't touch anything inside docs.

@novusnota novusnota added kind: docs Documentation for docs.tact-lang.org kept in docs folder scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky) labels Mar 28, 2025
@novusnota novusnota added this to the Doc: 2025-03 milestone Mar 28, 2025
@novusnota novusnota self-assigned this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: docs Documentation for docs.tact-lang.org kept in docs folder scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant