Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path to checker-qual jar #27

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix path to checker-qual jar #27

merged 1 commit into from
Apr 3, 2024

Conversation

kelloggm
Copy link
Collaborator

@kelloggm kelloggm commented Apr 3, 2024

@kelloggm kelloggm requested a review from tahiat April 3, 2024 15:00
@kelloggm
Copy link
Collaborator Author

kelloggm commented Apr 3, 2024

Overriding approval requirements because Specimin's main CI branch is failing, and the fix (github.com/kelloggm/specimin/pulls/223) is blocked on this.

@kelloggm kelloggm requested a review from LoiNguyenCS April 3, 2024 15:30
LoiNguyenCS
LoiNguyenCS approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@LoiNguyenCS LoiNguyenCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoiNguyenCS LoiNguyenCS merged commit f6bcdae into main Apr 3, 2024
1 check passed
@kelloggm kelloggm deleted the fix-checker-qual-path branch April 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoiNguyenCS LoiNguyenCS LoiNguyenCS approved these changes

@tahiat tahiat Awaiting requested review from tahiat

Assignees

@tahiat tahiat

@LoiNguyenCS LoiNguyenCS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelloggm @LoiNguyenCS @tahiat