-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 support #100
Python 3.12 support #100
Conversation
Most of the changes are just upgrading versioneer. |
@itamarst I too do not know what the deal is with both NEWS.txt and changelog, although I myself have added some notes to both of them (sorry!). What do you think would be the right thing to do? It also bugs me that we get a bunch of deployment errors from PR checks, because zfec version that CI attempts to upload already exists on testpypi. Maybe we should skip testpypi upload? Relatedly, is it a good idea to continue vendoring versioneer anymore? Perhaps setuptools_scm (or similar) will do an acceptable job, and if we switch to setuptools_scm testpypi publishing will stop failing? |
Wait, testpypi uploads are failing with a different error now:
Pretty sure that the earlier pypi upload failures were because of attempts to re-upload existing versions of zfec package. |
I am not sure |
What I've seen is that setuptools_scm will insert a git short commit hash in the package name (resulting in package names of the form |
I thought versioneer did that too, e.g. on my (untagged) fork, it gives |
Ah okay, versioneer should be able to do the job just fine then. I will look into these testpypi failures when I get a chance. |
Note that you'll have to merge it, since I don't have permissions to do so. |
I think this error is due to the PR being submitted from a fork and so not having access to any secrets. |
Fixes #99
Not sure what's up with both NEWS and ChangeLog existing, so didn't do an entry. Someone with permissions will have to do a release once this is merged.