Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #100

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

itamarst
Copy link

Fixes #99

Not sure what's up with both NEWS and ChangeLog existing, so didn't do an entry. Someone with permissions will have to do a release once this is merged.

@itamarst
Copy link
Author

Most of the changes are just upgrading versioneer.

@sajith
Copy link
Member

sajith commented Oct 18, 2023

@itamarst I too do not know what the deal is with both NEWS.txt and changelog, although I myself have added some notes to both of them (sorry!). What do you think would be the right thing to do?

It also bugs me that we get a bunch of deployment errors from PR checks, because zfec version that CI attempts to upload already exists on testpypi. Maybe we should skip testpypi upload?

Relatedly, is it a good idea to continue vendoring versioneer anymore? Perhaps setuptools_scm (or similar) will do an acceptable job, and if we switch to setuptools_scm testpypi publishing will stop failing?

@sajith
Copy link
Member

sajith commented Oct 18, 2023

Wait, testpypi uploads are failing with a different error now:

ERROR    HTTPError: 403 Forbidden from https://test.pypi.org/legacy/            
         Invalid or non-existent authentication information. See                
         https://test.pypi.org/help/#invalid-auth for more information.    

Pretty sure that the earlier pypi upload failures were because of attempts to re-upload existing versions of zfec package.

@itamarst
Copy link
Author

I am not sure setuptools_scm would make any difference; if the issue is it has the same version, that would still be the case I think? In theory there's some post-version stuff, not sure why that's not triggered.

@sajith
Copy link
Member

sajith commented Oct 19, 2023

What I've seen is that setuptools_scm will insert a git short commit hash in the package name (resulting in package names of the form zfec-x.y.z+deadb33f-cp32-abi3-linux_x86_64.whl), so testpypi uploads will have unique names.

@itamarst
Copy link
Author

I thought versioneer did that too, e.g. on my (untagged) fork, it gives zfec-0.post0.dev675-cp312-cp312-linux_x86_64.whl.

@sajith
Copy link
Member

sajith commented Oct 19, 2023

Ah okay, versioneer should be able to do the job just fine then.

I will look into these testpypi failures when I get a chance.

@itamarst
Copy link
Author

Note that you'll have to merge it, since I don't have permissions to do so.

@exarkun
Copy link
Member

exarkun commented Oct 19, 2023

Wait, testpypi uploads are failing with a different error now:

ERROR    HTTPError: 403 Forbidden from https://test.pypi.org/legacy/            
         Invalid or non-existent authentication information. See                
         https://test.pypi.org/help/#invalid-auth for more information.    

Pretty sure that the earlier pypi upload failures were because of attempts to re-upload existing versions of zfec package.

I think this error is due to the PR being submitted from a fork and so not having access to any secrets.

@exarkun exarkun merged commit dc1d65d into tahoe-lafs:master Oct 19, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 support
4 participants